[Mesa-dev] [PATCH 1/2] mesa: Flag _NEW_BUFFERS when unbinding an attachment on glDeleteTextures.
Eric Anholt
eric at anholt.net
Wed May 25 17:23:51 PDT 2011
This is part of fixing valgrind complaints on fbo-finish-deleted on
intel (sadly, the test doesn't segfault for me). The
_ColorDrawBuffers[] wouldn't get updated despite us having updated
what it depends on (Attachments[]->Renderbuffer). Other callers of
_mesa_remove_attachment are already flagging _NEW_BUFFERS for other
reasons.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=33656
---
src/mesa/main/texobj.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c
index fdf1281..565a3a2 100644
--- a/src/mesa/main/texobj.c
+++ b/src/mesa/main/texobj.c
@@ -879,6 +879,8 @@ unbind_texobj_from_fbo(struct gl_context *ctx,
for (j = 0; j < BUFFER_COUNT; j++) {
if (fb->Attachment[j].Type == GL_TEXTURE &&
fb->Attachment[j].Texture == texObj) {
+ /* Vertices are already flushed by _mesa_DeleteTextures */
+ ctx->NewState |= _NEW_BUFFERS;
_mesa_remove_attachment(ctx, fb->Attachment + j);
}
}
--
1.7.5.1
More information about the mesa-dev
mailing list