[Mesa-dev] [PATCH 2/2] i965: Use new vtable entries for surface state updating functions.

[Eric Anholt]

On Tue,  8 Nov 2011 10:39:45 -0800, Kenneth Graunke <kenneth at whitecape.org> wrote:
> Now that we have vtable entries in place, we should use them.  This
> allows us to drop the cut and pasted Gen7 brw_tracked_state atoms as
> they now do exactly the same thing as their brw_wm_surface_state
> counterparts.
> 
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>

Both are

Reviewed-by: Eric Anholt <eric at anholt.net>

> -const struct brw_tracked_state gen7_wm_surfaces = {
> -   .dirty = {
> -      .mesa = (_NEW_COLOR |
> -               _NEW_TEXTURE |
> -               _NEW_BUFFERS),
> -      .brw = (BRW_NEW_BATCH |
> -	      BRW_NEW_WM_CONSTBUF),
> -      .cache = 0
> -   },
> -   .emit = gen7_upload_wm_surfaces,
> -};

One oddness is that gen7 (and gen6) was flagging _NEW_COLOR when it
doesn't have to, since colormask is in the color calculator now.
However, we could avoid that by making the atom non-const and tweaking
it at vtbl init time, now that we don't memcpy atoms around.  So this
patch doesn't make that future optimization harder.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111108/427cd2d7/attachment.pgp>