[Mesa-dev] [PATCH 08/10] meta: Add support for glClear() to integer color buffers.

[Eric Anholt]

On Tue, 08 Nov 2011 19:46:13 -0800, Kenneth Graunke <kenneth at whitecape.org> wrote:
> On 11/04/2011 03:01 PM, Eric Anholt wrote:
> > This requires using a new fragment shader to get the integer color
> > output, and a new vertex shader because #version has to match between
> > the two.
> 
> Hm.  The extra VS is rather unfortunate (it's exactly the same other
> than the #version), but I suppose necessary.
> 
> One comment...
> 
> You don't appear to have any code to associate "out_color" with a
> location; I suppose it's implicitly 0 since it's the only output.  Is it
> worth setting this explicitly?
> 
> I'll accept "No, it's fine" as an answer. :)
> 
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

Given that I had to look up the spec saying that assignment starts from
0, yes, it does merit a comment explaining why this works.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111109/57754b5a/attachment-0001.pgp>