[Mesa-dev] [PATCH 1/2] gallium: add TGSI_SEMANTIC_VERTEXID

[Brian Paul]

On 11/14/2011 08:08 AM, Jose Fonseca wrote:
>
>
> ----- Original Message -----
>> On 12.11.2011 00:30, Brian Paul wrote:
>>> On 11/11/2011 04:18 PM, Christoph Bumiller wrote:
>>>> On 11.11.2011 23:59, Brian Paul wrote:
>>>>> On 11/11/2011 03:18 PM, Christoph Bumiller wrote:
>>>>>> ---
>>>>>>     src/gallium/auxiliary/tgsi/tgsi_dump.c     |    1 +
>>>>>>     src/gallium/auxiliary/tgsi/tgsi_scan.c     |    3 +++
>>>>>>     src/gallium/auxiliary/tgsi/tgsi_scan.h     |    1 +
>>>>>>     src/gallium/auxiliary/tgsi/tgsi_text.c     |    1 +
>>>>>>     src/gallium/include/pipe/p_shader_tokens.h |    5 +++--
>>>>>>     5 files changed, 9 insertions(+), 2 deletions(-)
>>>>>>
>>>>>> diff --git a/src/gallium/auxiliary/tgsi/tgsi_dump.c
>>>>>> b/src/gallium/auxiliary/tgsi/tgsi_dump.c
>>>>>> index 64927ed..91bc124 100644
>>>>>> --- a/src/gallium/auxiliary/tgsi/tgsi_dump.c
>>>>>> +++ b/src/gallium/auxiliary/tgsi/tgsi_dump.c
>>>>>> @@ -128,6 +128,7 @@ static const char *semantic_names[] =
>>>>>>        "EDGEFLAG",
>>>>>>        "PRIM_ID",
>>>>>>        "INSTANCEID",
>>>>>> +   "VERTEXID",
>>>>>>        "STENCIL"
>>>>>>     };
>>>>>>
>>>>>
>>>> [...]
>>>>> Reviewed-by: Brian Paul<brianp at vmware.com>
>>>>>
>>>>>
>>>>> Looks good, but doesn't seem to help with
>>>>> https://bugs.freedesktop.org/show_bug.cgi?id=42834
>>>>>
>>>> That's what the next one is for, didn't want to mix state tracker
>>>> specific and pure-gallium changes.
>>>> FWIW, I've tested both piglit/vertexid and piglit/draw-instanced
>>>> on nvc0
>>>> and they pass.
>>>
>>> I meant that I applied both patches in the series and it didn't
>>> help
>>> with the bug.  Maybe I need to do a fresh rebuild or something.
>>>
>>> Can you test softpipe?
>>>
>> Done. WORKSFORME. On softpipe.
>
> Brian,
>
> Christoph's series also fixes llvmpipe regression for me, built w/ scons, so must be some issue w/ dependencies on your local tree.

OK, I haven't gotten around to rebuilding and retesting from scratch 
yet.  That's probably it.

-Brian