[Mesa-dev] [PATCH] read_rgba_pixels: Don't force clamping if the renderbuffer is already clamped.

Brian Paul brianp at vmware.com
Wed Nov 16 13:20:43 PST 2011


On 11/16/2011 09:44 AM, Michel Dänzer wrote:
> From: Michel Dänzer<michel.daenzer at amd.com>
>
> Signed-off-by: Michel Dänzer<michel.daenzer at amd.com>
> ---
>   src/mesa/main/readpix.c |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c
> index 8550618..582adc3 100644
> --- a/src/mesa/main/readpix.c
> +++ b/src/mesa/main/readpix.c
> @@ -285,7 +285,8 @@ read_rgba_pixels( struct gl_context *ctx,
>         return;
>
>      if ((ctx->Color._ClampReadColor == GL_TRUE || type != GL_FLOAT)&&
> -       !_mesa_is_integer_format(format)) {
> +       !_mesa_is_integer_format(format)&&
> +       _mesa_get_format_datatype(rb->Format) != GL_UNSIGNED_NORMALIZED) {
>         transferOps |= IMAGE_CLAMP_BIT;
>      }
>

Looks good to me.

Reviewed-by: Brian Paul <brianp at vmware.com>


More information about the mesa-dev mailing list