[Mesa-dev] [PATCH 28/41] i965: Resolve buffers before drawing

[Eric Anholt]

On Thu, 17 Nov 2011 19:58:55 -0800, Chad Versace <chad.versace at linux.intel.com> wrote:
> Before emitting primitives in brw_try_draw_prims(), resolve the depth
> buffer's HiZ buffer and resolve the depth buffer of each enabled depth
> texture.
> 
> Signed-off-by: Chad Versace <chad.versace at linux.intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_draw.c |   73 ++++++++++++++++++++++++++++++++++
>  1 files changed, 73 insertions(+), 0 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c
> index d2ae087..88e0194 100644
> --- a/src/mesa/drivers/dri/i965/brw_draw.c
> +++ b/src/mesa/drivers/dri/i965/brw_draw.c

> @@ -316,6 +384,11 @@ static bool brw_try_draw_prims( struct gl_context *ctx,
>      */
>     brw_validate_textures( brw );
>  
> +   /* Resolves must occur after updating state and finalizing textures but
> +    * before validating drm bo's.
> +    */
> +   brw_predraw_resolve_buffers(brw);
> +

Validating drm BOs doesn't exist any more (hooray!), but I would still
say "before setting up any hardware state for this draw call".
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111118/66b8d2d0/attachment.pgp>