[Mesa-dev] [PATCH 1/6] glsl: finish up ARB_conservative_depth

Marek Olšák maraeo at gmail.com
Sat Nov 19 07:42:44 PST 2011

On Fri, Nov 18, 2011 at 9:44 PM, Ian Romanick <idr at freedesktop.org> wrote:
> On 11/18/2011 11:27 AM, Marek Olšák wrote:
> This patch also needs to change the _mesa_glsl_supported_extensions table in
> glsl_parser_extras.cpp.  AMD_conservative_depth is used for both versions of
> the extension in the table.

But that refers to the single extension flag in mtypes.h and there's
only one: the AMD one. Not sure what else I should change in that

> I'm not super convinced that we even need separate enable flags.  Both
> extensions add the exact same functionality using the exact same layout
> qualifiers.  It's not a big deal to me either way, though.

I guess this would end up being incorrect with unified flags:

#extension GL_AMD_conservative_depth : enable
#extension GL_ARB_conservative_depth : disable // would disable AMD too

Just a thought.


More information about the mesa-dev mailing list