[Mesa-dev] [PATCH] linker: Remove erroneous multiply by 4 in uniform usage calculation

Eric Anholt eric at anholt.net
Mon Nov 21 13:27:01 PST 2011


On Mon, 21 Nov 2011 11:51:13 -0800, "Ian Romanick" <idr at freedesktop.org> wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> The old count_uniform_size::num_shader_uniforms was actually
> calculating the number of components used.  Multiplying by 4 when
> setting gl_shader::num_uniform_components caused us to count 4x as
> many uniform components as were actually used.

> @@ -182,6 +182,7 @@ private:
>         */
>        this->num_active_uniforms++;
>        this->num_values += values;
> +      printf("%s: %d\n", name, values);

Debug printf left around.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111121/855d635d/attachment.pgp>


More information about the mesa-dev mailing list