[Mesa-dev] [PATCH] linker: Remove erroneous multiply by 4 in uniform usage calculation

Kenneth Graunke kenneth at whitecape.org
Mon Nov 21 20:08:08 PST 2011

On 11/21/2011 11:51 AM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> The old count_uniform_size::num_shader_uniforms was actually
> calculating the number of components used.  Multiplying by 4 when
> setting gl_shader::num_uniform_components caused us to count 4x as
> many uniform components as were actually used.

Yes, this looks correct.  Also seems to fix crashes in Civilization 4.

Reviewed-and-tested-by: Kenneth Graunke <kenneth at whitecape.org>

Thanks, Ian.

More information about the mesa-dev mailing list