[Mesa-dev] [PATCH] glsl: disable resource checking in the linker until it's done right

[Jose Fonseca]

----- Original Message -----
> On 11/22/2011 06:47 AM, Jose Fonseca wrote:
> > ----- Original Message -----
> >> There's over a month before what is currently master will be
> >> released.
> >> People that don't like this bug can use a stable release.
> >
> > This will drive testers affected by this issue away from testing
> > master. I thought that we all agreed that master should remain
> > relatively stable all the time. No good comes from leaving things
> > broken
> > for our users like this for so long.

Note that by "so long" I was meaning the one+ month period from when this was wrote until the next Mesa release, not the time since the commit (the past week or so). That is, I was simply stating the urgency of finding a compromise (even on master), and no intention of blaming anybody.

> That's fair.  It's worth pointing out a couple things about this:
> 
> 1. These patches sat on the mailing list for a week and received
> *zero*
> review comments from anyone outside Intel.

By rule I don't comment on components I'm not familiar with (and the reason I'm not familiar with GLSL compiler is lack of time, not interest), and furthermore I've been doing very little Mesa related development lately, but I admit I should pay more attention at least to the changes that have side-effects on modules I care about.

> 2. The actual bug was fixed by commit 151867b4 a week after that.

Thanks for fixing this Ian.

I confess I'm surprised this was fixable without replicating the r300 optimizations in glsl compiler, as my understanding was that r300 limits matched SM3 precisely, and WINE generated shaders that exceeded those limits slightly. Guess not.

Anyway, I'm happy to see this issue die.

Jose