[Mesa-dev] [PATCH 2/5] mesa: define _MESA_NEW_SEPARATE_SPECULAR

[Brian Paul]

On 11/23/2011 11:58 AM, Eric Anholt wrote:
> On Tue, 22 Nov 2011 18:07:01 -0700, Brian Paul<brianp at vmware.com>  wrote:
>> This will replace the soon-to-be-removed _DD_NEW_SEPARATE_SPECULAR flag.
>> ---
>>   src/mesa/main/mtypes.h |    6 ++++++
>>   src/mesa/main/state.c  |    4 ++--
>>   2 files changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
>> index e8866c6..c94a065 100644
>> --- a/src/mesa/main/mtypes.h
>> +++ b/src/mesa/main/mtypes.h
>> @@ -3130,6 +3130,12 @@ struct gl_matrix_stack
>>                                              _NEW_POINT |		\
>>                                              _NEW_PROGRAM |	\
>>                                              _NEW_MODELVIEW)
>> +
>> +#define _MESA_NEW_SEPARATE_SPECULAR        (_NEW_LIGHT | \
>> +                                            _NEW_FOG | \
>> +                                            _NEW_PROGRAM)
>> +
>> +
>>   /*@}*/
>
> Having this one be _MESA_NEW_ looks weird to me.  I think I'd like to
> have a couple more of these kinds of flags for computed state based off
> of multiple _NEW_ bits, that look just like the rest of the _NEW_ flags.

I was just following the example of the preceeding 
_MESA_NEW_NEED_EYE_COORDS definition (which isn't visible in the patch).

I don't have a strong preference for the name.  I'd be happy to change 
the names of both in a follow-on patch.

-Brian