[Mesa-dev] [PATCH] mesa: fix frag shader generation for alpha test with no color buffers

Eric Anholt eric at anholt.net
Thu Nov 24 11:35:49 PST 2011

On Wed, 23 Nov 2011 15:08:23 -0800, Ian Romanick <idr at freedesktop.org> wrote:
> On 11/23/2011 02:35 PM, Brian Paul wrote:
> > If alpha test is enabled and there's no color buffers we still need the
> > fragment shader to emit a color.
> >
> > Fixes piglit fbo-alphatest-nocolor-ff failures with Gallium drivers.
> It looks like this an Eric's recent patch 
> (http://lists.freedesktop.org/archives/mesa-dev/2011-November/015049.html) 
> may trip over each other.  You guys should sort this out.

Nope, this should fix the other piglit test related to alpha test with
no color.

The patch looks good, except that the _NEW_COLOR state flag in use here
is new, and would need to be added to prog_flags in state.c.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111124/57c6e23a/attachment.pgp>

More information about the mesa-dev mailing list