[Mesa-dev] [PATCH 1/3] mesa/formats: add mesa MESA_FORMAT_ARGB2101010_UINT description.

[Brian Paul]

On 11/28/2011 02:24 AM, Dave Airlie wrote:
> On Sun, Nov 27, 2011 at 10:42 PM, Eric Anholt<eric at anholt.net>  wrote:
>> On Sun, 27 Nov 2011 19:27:15 +0000, Dave Airlie<airlied at gmail.com>  wrote:
>>> From: Dave Airlie<airlied at redhat.com>
>>>
>>> This format is used in the ARB_texture_rgb10_a2ui spec.
>>>
>>> Signed-off-by: Dave Airlie<airlied at redhat.com>
>>> ---
>>>   src/mesa/main/formats.c |   17 +++++++++++++++++
>>>   src/mesa/main/formats.h |    2 ++
>>>   2 files changed, 19 insertions(+), 0 deletions(-)
>>
>>> diff --git a/src/mesa/main/formats.h b/src/mesa/main/formats.h
>>> index 5f60186..8699092 100644
>>> --- a/src/mesa/main/formats.h
>>> +++ b/src/mesa/main/formats.h
>>> @@ -265,6 +265,8 @@ typedef enum
>>>      MESA_FORMAT_Z32_FLOAT,
>>>      MESA_FORMAT_Z32_FLOAT_X24S8,
>>>
>>> +   MESA_FORMAT_ARGB2101010_UINT,
>>> +
>>>      MESA_FORMAT_COUNT
>>>   } gl_format;
>>
>> Hmm, are we at the point yet where we can safely put new enums somewhere
>> more sensible than "at the end of the list"?
>
> Don't think so, format_info itself is still required in enum ordering,
> so I won't be taking that chance yet.

I think the only places where we initialize tables in the order of the 
gl_format enums is in formats.c and s_texfetch.c.  In both cases 
there's assertions that check that the tables are consistent.


> and really we must nearly be out of formats, BPTC is all I can see
> coming we might be needing :-)

I don't see too many new formats coming along either.

-Brian