[Mesa-dev] [PATCH 1/3] i965: Don't double the depth width for separate-stencil-only rendering.

[Eric Anholt]

On Mon, 28 Nov 2011 15:46:38 -0800, Chad Versace <chad.versace at linux.intel.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> The code that this patch fixes is indeed correct, but not for the reason you believe.
> 
> On 11/28/2011 10:48 AM, Eric Anholt wrote:
> > This looks to have been confused with pitch setup, which does have to
> > be doubled.
> 
> It was intentional.
> 
> > The width is inherited by separate stencil, and it should
> > naturally look like the setup in the block below involving a valid
> > depthbuffer.
> 
> I disagree. The setup in the block below is different because
> depth_irb->region->height is the depth buffer's height, but
> stencil_irb->region->height is not the stencil buffer's height.
> That's because of the hack we resort to when allocating stencil
> buffers.

Tricky.  I just stumbled over this half an hour ago in the mapping
cleanup I'm doing, too, and had concluded that rb->Height was the thing
I wanted to use there.  I like your proposed hunk.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111128/bb9cb997/attachment.pgp>