[Mesa-dev] [PATCH 3/7] mesa: add ETC1 decoding routines

[Chia-I Wu]

On Wed, Nov 30, 2011 at 10:10 PM, Brian Paul <brianp at vmware.com> wrote:
> On 11/29/2011 09:47 PM, Chia-I Wu wrote:
>>
>> From: Chia-I Wu<olv at lunarg.com>
>>
>> The format is defined by GL_OES_compressed_ETC1_RGB8_texture.  These
>> routines
>> will be used in the following commit.
>> ---
>>  src/mesa/main/texcompress_etc1.c     |   71 ++++++++++++++++++
>>  src/mesa/main/texcompress_etc1.h     |   40 ++++++++++
>>  src/mesa/main/texcompress_etc1_tmp.h |  136
>> ++++++++++++++++++++++++++++++++++
>>  src/mesa/sources.mak                 |    1 +
>>  4 files changed, 248 insertions(+), 0 deletions(-)
>>  create mode 100644 src/mesa/main/texcompress_etc1.c
>>  create mode 100644 src/mesa/main/texcompress_etc1.h
>>  create mode 100644 src/mesa/main/texcompress_etc1_tmp.h
>>
>
> [...]
>
>
>> diff --git a/src/mesa/sources.mak b/src/mesa/sources.mak
>> index e72a1ce..87094f2 100644
>> --- a/src/mesa/sources.mak
>> +++ b/src/mesa/sources.mak
>> @@ -83,6 +83,7 @@ MAIN_SOURCES = \
>>        main/texcompress_rgtc.c \
>>        main/texcompress_s3tc.c \
>>        main/texcompress_fxt1.c \
>> +       main/texcompress_etc1.c \
>>        main/texenv.c \
>>        main/texformat.c \
>>        main/texgen.c \
>
>
> Does texcompress_etc1.c need to be added to SConscript too?
Ah, right, thanks.

> Otherwise, the series looks good to me.
>
> Reviewed-by: Brian Paul <brianp at vmware.com>
Thanks for the review.
> -Brian



-- 
olv at LunarG.com