[Mesa-dev] [PATCH 1/5] mesa: Skip texstore for 0-sized texture data.

[Eric Anholt]

On Tue, 25 Oct 2011 16:29:53 -0600, Brian Paul <brianp at vmware.com> wrote:
> On 10/25/2011 03:58 PM, Eric Anholt wrote:
> > The intel driver (and gallium, it looks like, though it doesn't use
> > these texstore functions at this point) doesn't bother making storage
> > for textures with 0 width, height, or depth.  This avoids them having
> > to deal with returning a mapping for that nonexistent data.
> >
> > Fixes assertion failures with an upcoming intel driver change.
> 
> For the series:  Reviewed-by: Brian Paul <brianp at vmware.com>
> 
> 
> However, there are some additional issues with texture borders that 
> have existed all along that we should probably fix up in follow-on 
> patches.
> 
> Suppose we've got a GL_TEXTURE_2D_ARRAY texture, if there's a border, 
> it only applies to the width and height, not the depth.  So we don't 
> want to change the texture depth in this case.  Similarly for 1D 
> texture arrays and the height.

Funny, I'd fixed a bug related to the 1D_ARRAY border handling before,
and totally missed that we were messing it up here, too.

Still, I agree on pushing ahead with this.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111026/09dd33c3/attachment.pgp>