[Mesa-dev] [PATCH 1/5] glsl: Fix copy-paste error in constant_expression_value(ir_binop_nequal)

Eric Anholt eric at anholt.net
Thu Oct 27 08:43:15 PDT 2011


On Wed, 26 Oct 2011 18:42:52 -0700, Paul Berry <stereotype441 at gmail.com> wrote:
> The implementation of ir_binop_nequal in constant_expression_value()
> appears to have been copy-and-pasted from the implementation of
> ir_binop_equal, but with all instances of '==' changed to '!='.  This
> is correct except for one minor flaw: one of those '==' operators was
> in an assertion checking that the types of the two arguments were
> equal.  That one needs to stay an '=='.

This series is

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111027/506049a2/attachment.pgp>


More information about the mesa-dev mailing list