[Mesa-dev] [PATCH] r600g: Replace needless flush in texture upload.

[Marek Olšák]

Looks good to me. Ideally even texture_barrier should not be needed.
set_framebuffer_state() and flush() should flush caches automatically.
If they don't, there is a bug.

Marek

2011/10/27 Mathias Fröhlich <Mathias.Froehlich at gmx.net>:
>
> Hi,
>
> On Saturday, October 22, 2011 13:36:37 Mathias Fröhlich wrote:
>> The attached patch reduces the amount of pipe flushes for r600g.
>> I am not exactly sure if we could skip this flush entirely because of the
>> internal r600g winsys flush logic.
>> But what we can do is the attached patch:
>>
>> Replace pipe->flush() with pipe->texture_barrier() in
>> the texture upload path for the staging texture.
>> This should be enough to get data out of the gpu
>> caches ready to be read for texture fetch.
>>
>> Please review.
> Any comment on that?
>
> May be I need to mention that it passed r600g piglit tests on an rv770 and
> rv635.
> Additionally I am running that on my installed systems since july.
>
> Thanks
>
> Mathias
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>