[Mesa-dev] [PATCH] r600g: Replace needless flush in texture upload.
Mathias Fröhlich
Mathias.Froehlich at gmx.net
Sat Oct 29 09:54:22 PDT 2011
Hi,
On Thursday, October 27, 2011 18:17:41 Marek Olšák wrote:
> Looks good to me. Ideally even texture_barrier should not be needed.
> set_framebuffer_state() and flush() should flush caches automatically.
> If they don't, there is a bug.
I have pushed this now as an improovement above the former code.
Due to lack of time I did not look into improoving this further ...
As you all mentioned, most of the buffer overlap flush logic must be already
there. At the time I queued that up in my tree piglit passed even when the
flush is just omitted without any replacement. I am just not sure if it's
guaranteed in any case that this is sufficient.
Thanks
Mathias
More information about the mesa-dev
mailing list