[Mesa-dev] i965 batch rollback: no more prepare() vs emit().

[Paul Berry]

On 24 October 2011 14:16, Eric Anholt <eric at anholt.net> wrote:

> I did do some testing by making libdrm claim a smaller aperture size
> and thus trigger the rollback code, which caught one bug.  Generally,
> piglit doesn't trigger rollback at all, which is a bit concerning from
> a testing coverage standpoint.
>
> For people reviewing, I think the interesting part to review is mostly
> making sure that my assertions about the incremental changes of moving
> things from prepare() to emit() are true.  A particular risk would be
> if I moved something from prepare() time (before all emit() calls) to
> emit() time (after some emit() calls) without noticing the dependency
> by those emits() in between.
>
> No noticeable performance impact from the change, though I was hoping
> to drop CPU usage a bit.  Oh well.
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>

I don't understand enough of the code to give a reviewed-by, but I've read
through all of it, and other than the comments I've already made, nothing
jumped out at me as a problem.

Acked-by: Paul Berry <stereotype441 at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111027/2c9c1572/attachment.htm>