[Mesa-dev] [PATCH 17/20] i965: Move _mesa_ir_link_shader call before device-specific linking

Eric Anholt eric at anholt.net
Fri Oct 28 14:59:30 PDT 2011


On Fri, 28 Oct 2011 10:42:44 -0700, "Ian Romanick" <idr at freedesktop.org> wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> _mesa_ir_link_shader needs to be called before cloning the IR tree so
> that the var->location field for uniforms is set.
> 
> WARNING: This change breaks several integer division related piglit
> tests.  The tests break because _mesa_ir_link_shader lowers integer
> division to an RCP followed by a MUL.  The fix is to factor out more
> of the code from ir_to_mesa so that _mesa_ir_link_shader does not need
> to be called at all by the i965 driver.  This will be the subject of
> several follow-on patches.

How close are we to avoiding Mesa IR at this point?  I'd rather see us
hack in something to suppress that lowering or something if it's going
to be very long.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111028/06e61b9c/attachment.pgp>


More information about the mesa-dev mailing list