[Mesa-dev] [PATCH 00/36] i965: Keep track of vertex attribute layout explicitly

[Eric Anholt]

On Fri,  2 Sep 2011 09:06:39 -0700, Paul Berry <stereotype441 at gmail.com> wrote:
> This patch series modifies the i965 driver code that relates to
> the layout of vertex attributes in the VUE (vertex URB entry).
> Previously the layout of vertex attributes was implicit in a
> large number of different source files, and was not always
> consistent (for instance, some code forgot to account for the
> fact that gl_PointSize is stored in the VUE header rather than as
> a separate interpolated attribute, resulting in subtle bugs for
> shaders that set gl_PointSize).  There were also a number of
> fragile assumptions about the relationship between VUE layout,
> the structure of the gl_vert_result enum, and the structure of
> the gl_frag_attrib enum.

I've sent out comments for some of the patches, and the remainder are:

Reviewed-by: Eric Anholt <eric at anholt.net>

When I'm reviewing, I try to make it a personal policy to follow up on
at least one assumption in each patch and verify it.  The number of
times that I did that it in this series without finding any problems was
awesome.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110902/8cda4af1/attachment.pgp>