[Mesa-dev] [PATCH] st/mesa: Finalize texture on render-to-texture.

Michel Dänzer michel at daenzer.net
Thu Sep 15 03:55:34 PDT 2011

On Mit, 2011-09-14 at 11:44 -0600, Brian Paul wrote:
> On 09/14/2011 11:16 AM, Michel Dänzer wrote:
> > From: Michel Dänzer<michel.daenzer at amd.com>
> >
> > This makes sure that stObj->pt exists and is up to date.
> >
> > Fixes https://bugs.freedesktop.org/show_bug.cgi?id=39193 .
> >
> > Signed-off-by: Michel Dänzer<michel.daenzer at amd.com>


> Reviewed-by: Brian Paul <brianp at vmware.com>

Thanks, Brian.

> I assume there's no piglit regressions.

There are no regressions per se with quick-driver.tests, but there's a
change for the fbo-incomplete-texture-03 test: Without this patch, it
fails with "FBO clear didn't work". With this patch, it passes without
--enable-debug or with GALLIUM_ABORT_ON_ASSERT=0, but there are some
assertion failures: 

state_tracker/st_texture.c:369:st_texture_image_copy: Assertion `u_minify(src->width0, srcLevel) == width' failed.
state_tracker/st_texture.c:370:st_texture_image_copy: Assertion `u_minify(src->height0, srcLevel) == height' failed.

Not sure if this is a new problem introduced by this patch, or an old
one uncovered by it, but I'm leaning towards the latter. 

Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer

More information about the mesa-dev mailing list