[Mesa-dev] [PATCH 10/10] radeon: Drop mapping we were doing around glGetTexImage().

Eric Anholt eric at anholt.net
Thu Sep 22 17:14:48 PDT 2011


It's handled by MapTextureImage() now.
---
 src/mesa/drivers/dri/r200/Makefile                |    1 -
 src/mesa/drivers/dri/r300/Makefile                |    1 -
 src/mesa/drivers/dri/r600/Makefile                |    1 -
 src/mesa/drivers/dri/radeon/Makefile              |    1 -
 src/mesa/drivers/dri/radeon/radeon_tex_getimage.c |   76 ---------------------
 src/mesa/drivers/dri/radeon/radeon_texture.c      |    1 -
 src/mesa/drivers/dri/radeon/radeon_texture.h      |    5 --
 7 files changed, 0 insertions(+), 86 deletions(-)
 delete mode 100644 src/mesa/drivers/dri/radeon/radeon_tex_getimage.c

diff --git a/src/mesa/drivers/dri/r200/Makefile b/src/mesa/drivers/dri/r200/Makefile
index 4547f7e..60d9c49 100644
--- a/src/mesa/drivers/dri/r200/Makefile
+++ b/src/mesa/drivers/dri/r200/Makefile
@@ -27,7 +27,6 @@ RADEON_COMMON_SOURCES = \
 	radeon_span.c \
 	radeon_texture.c \
 	radeon_tex_copy.c \
-	radeon_tex_getimage.c \
 	radeon_tile.c
 
 DRIVER_SOURCES = r200_context.c \
diff --git a/src/mesa/drivers/dri/r300/Makefile b/src/mesa/drivers/dri/r300/Makefile
index a0a00e0..55c7580 100644
--- a/src/mesa/drivers/dri/r300/Makefile
+++ b/src/mesa/drivers/dri/r300/Makefile
@@ -27,7 +27,6 @@ RADEON_COMMON_SOURCES = \
 	radeon_span.c \
 	radeon_texture.c \
 	radeon_tex_copy.c \
-	radeon_tex_getimage.c \
 	radeon_tile.c
 
 DRIVER_SOURCES = \
diff --git a/src/mesa/drivers/dri/r600/Makefile b/src/mesa/drivers/dri/r600/Makefile
index 2adc352..7c15795 100644
--- a/src/mesa/drivers/dri/r600/Makefile
+++ b/src/mesa/drivers/dri/r600/Makefile
@@ -27,7 +27,6 @@ RADEON_COMMON_SOURCES = \
 	radeon_span.c \
 	radeon_texture.c \
 	radeon_tex_copy.c \
-	radeon_tex_getimage.c \
 	radeon_tile.c
 
 DRIVER_SOURCES = \
diff --git a/src/mesa/drivers/dri/radeon/Makefile b/src/mesa/drivers/dri/radeon/Makefile
index 6b5d333..5ee8022 100644
--- a/src/mesa/drivers/dri/radeon/Makefile
+++ b/src/mesa/drivers/dri/radeon/Makefile
@@ -28,7 +28,6 @@ RADEON_COMMON_SOURCES = \
 	radeon_span.c \
 	radeon_texture.c \
 	radeon_tex_copy.c \
-	radeon_tex_getimage.c \
 	radeon_tile.c
 
 DRIVER_SOURCES = \
diff --git a/src/mesa/drivers/dri/radeon/radeon_tex_getimage.c b/src/mesa/drivers/dri/radeon/radeon_tex_getimage.c
deleted file mode 100644
index a72c2da..0000000
--- a/src/mesa/drivers/dri/radeon/radeon_tex_getimage.c
+++ /dev/null
@@ -1,76 +0,0 @@
-/*
- * Copyright (C) 2009 Maciej Cencora.
- * Copyright (C) 2008 Nicolai Haehnle.
- * Copyright (C) The Weather Channel, Inc.  2002.  All Rights Reserved.
- *
- * The Weather Channel (TM) funded Tungsten Graphics to develop the
- * initial release of the Radeon 8500 driver under the XFree86 license.
- * This notice must be preserved.
- *
- * Permission is hereby granted, free of charge, to any person obtaining
- * a copy of this software and associated documentation files (the
- * "Software"), to deal in the Software without restriction, including
- * without limitation the rights to use, copy, modify, merge, publish,
- * distribute, sublicense, and/or sell copies of the Software, and to
- * permit persons to whom the Software is furnished to do so, subject to
- * the following conditions:
- *
- * The above copyright notice and this permission notice (including the
- * next paragraph) shall be included in all copies or substantial
- * portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
- * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
- * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
- * IN NO EVENT SHALL THE COPYRIGHT OWNER(S) AND/OR ITS SUPPLIERS BE
- * LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
- * OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
- * WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
- *
- */
-
-#include "radeon_common_context.h"
-#include "radeon_texture.h"
-#include "radeon_mipmap_tree.h"
-
-#include "main/texgetimage.h"
-
-/**
- * Need to map texture image into memory before copying image data,
- * then unmap it.
- */
-void
-radeonGetTexImage(struct gl_context * ctx, GLenum target, GLint level,
-          GLenum format, GLenum type, GLvoid * pixels,
-          struct gl_texture_object *texObj,
-          struct gl_texture_image *texImage)
-{
-    radeon_texture_image *image = get_radeon_texture_image(texImage);
-
-    radeon_print(RADEON_TEXTURE, RADEON_NORMAL,
-                 "%s(%p, tex %p, image %p).\n",
-                 __func__, ctx, texObj, image);
-
-    if (image->mt) {
-        radeonContextPtr rmesa = RADEON_CONTEXT(ctx);
-        /* Map the texture image read-only */
-        if (radeon_bo_is_referenced_by_cs(image->mt->bo, rmesa->cmdbuf.cs)) {
-            radeon_print(RADEON_TEXTURE, RADEON_VERBOSE,
-                "%s: called for texture that is queued for GPU processing\n",
-                __func__);
-            radeon_firevertices(rmesa);
-        }
-
-        radeon_teximage_map(image, GL_FALSE);
-    } else {
-        /* Image hasn't been uploaded to a miptree yet */
-        assert(image->base.Base.Data);
-    }
-
-    _mesa_get_teximage(ctx, target, level, format, type, pixels,
-		       texObj, texImage);
-
-    if (image->mt) {
-        radeon_teximage_unmap(image);
-    }
-}
diff --git a/src/mesa/drivers/dri/radeon/radeon_texture.c b/src/mesa/drivers/dri/radeon/radeon_texture.c
index d7636ca..7f824ce 100644
--- a/src/mesa/drivers/dri/radeon/radeon_texture.c
+++ b/src/mesa/drivers/dri/radeon/radeon_texture.c
@@ -1191,7 +1191,6 @@ radeon_init_common_texture_funcs(radeonContextPtr radeon,
 	functions->TexSubImage3D = radeonTexSubImage3D;
 	functions->CompressedTexImage2D = radeonCompressedTexImage2D;
 	functions->CompressedTexSubImage2D = radeonCompressedTexSubImage2D;
-	functions->GetTexImage = radeonGetTexImage;
 
 	functions->GenerateMipmap = radeonGenerateMipmap;
 
diff --git a/src/mesa/drivers/dri/radeon/radeon_texture.h b/src/mesa/drivers/dri/radeon/radeon_texture.h
index 3d096b1..c68228b 100644
--- a/src/mesa/drivers/dri/radeon/radeon_texture.h
+++ b/src/mesa/drivers/dri/radeon/radeon_texture.h
@@ -117,11 +117,6 @@ void radeonTexSubImage3D(struct gl_context * ctx, GLenum target, GLint level,
 			 struct gl_texture_object *texObj,
 			 struct gl_texture_image *texImage);
 
-void radeonGetTexImage(struct gl_context * ctx, GLenum target, GLint level,
-		       GLenum format, GLenum type, GLvoid * pixels,
-		       struct gl_texture_object *texObj,
-		       struct gl_texture_image *texImage);
-
 void radeonCopyTexSubImage2D(struct gl_context *ctx, GLenum target, GLint level,
 			GLint xoffset, GLint yoffset,
 			GLint x, GLint y,
-- 
1.7.5.4



More information about the mesa-dev mailing list