[Mesa-dev] [PATCH] mesa: Also set the remaining draw buffers to GL_NONE when updating just the first buffer in _mesa_drawbuffers().

Eric Anholt eric at anholt.net
Fri Sep 23 10:02:01 PDT 2011

On Fri, 23 Sep 2011 03:04:21 +0200, Henri Verbeet <hverbeet at gmail.com> wrote:
Non-text part: multipart/mixed
> On 23 September 2011 01:48, Eric Anholt <eric at anholt.net> wrote:
> > In the case of n == 1 with more than one bit set, doesn't this stomp the
> > _ColorDrawBufferIndexes[] we just calculated between n and
> > _NumColorDrawBuffers - 1?  Looks like splitting that loop into two would
> > work well.
> >
> You're right, how about something like the attached patch? Strictly
> speaking the start index for the first loop should be MAX2(n,
> fb->_NumColorDrawBuffers), though I'm not sure that's worth it.

Looks good to me.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110923/4508174f/attachment.pgp>

More information about the mesa-dev mailing list