[Mesa-dev] MapTextureImage for glGetTexImage

[Eric Anholt]

On Fri, 23 Sep 2011 15:04:13 -0600, Brian Paul <brianp at vmware.com> wrote:
Non-text part: multipart/mixed
> On 09/22/2011 07:24 PM, Brian Paul wrote:
> > On Thu, Sep 22, 2011 at 6:14 PM, Eric Anholt<eric at anholt.net>  wrote:
> >> Here's an extract of what I had in one of my branches for mti, with a
> >> slight cleanup to reduce diffs in texgetimage.c.  Tested on i965 and
> >> softpipe.  This code can also be found in the mti-getteximage branch
> >> of my personal tree.
> >
> > I'll try to test this in the next day or two.  I'm working on a new
> > piglit test to exercise glGetTexImage().  It needs a bit more work but
> > it should find any potential bugs.
> 
> Only found one issue so far.  We need to do a map/unmap around the 
> call to _mesa_decompress_image().  Patch attached.
> 
> If you want to include that in your series, go for it.
> 
> Tested-by: Brian Paul <brianp at vmware.com>

Cool.  I had to clean up the hack a bit since it blew up for hardware's
pitch padding.  I *think* I worked out how texcompress.c wanted pitch
compared to MapTextureImage.

Did you make any progress on a piglit test?  I was really looking
forward to one, since I stalled on writing mine.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110927/703074f5/attachment.pgp>