[Mesa-dev] [PATCH 4/4] mesa: add _NEW_CURRENT_ATTRIB in _mesa_program_state_flags()

[Eric Anholt]

On Thu, 29 Sep 2011 14:24:48 -0600, Brian Paul <brian.e.paul at gmail.com> wrote:
> From: Brian Paul <brianp at vmware.com>
> 
> If color material mode is enabled, constant buffer entries related
> to the lighting coefficients will depend on glColor.  So add
> _NEW_CURRENT_ATTRIB to the bitset returned for lighting-related
> constants in _mesa_program_state_flags().
> 
> This fixes a bug exercised by the new piglit draw-arrays-colormaterial
> test.
> ---
>  src/mesa/program/prog_statevars.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/mesa/program/prog_statevars.c b/src/mesa/program/prog_statevars.c
> index 6aa2409..9c3d30c 100644
> --- a/src/mesa/program/prog_statevars.c
> +++ b/src/mesa/program/prog_statevars.c
> @@ -668,7 +668,7 @@ _mesa_program_state_flags(const gl_state_index state[STATE_LENGTH])
>     case STATE_LIGHTMODEL_AMBIENT:
>     case STATE_LIGHTMODEL_SCENECOLOR:
>     case STATE_LIGHTPROD:
> -      return _NEW_LIGHT;
> +      return _NEW_LIGHT | _NEW_CURRENT_ATTRIB;
>  
>     case STATE_TEXGEN:
>        return _NEW_TEXTURE;

Not that we care a whole ton about fixed function lighting performance,
but I don't think this flag applies to STATE_LIGHT (the others are all
true, though).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110929/d5ec9938/attachment.pgp>