[Mesa-dev] [PATCH 1/2] vbo: do FLUSH_CURRENT before validating and updating state
Marek Olšák
maraeo at gmail.com
Mon Apr 23 07:16:50 PDT 2012
On Mon, Apr 23, 2012 at 3:58 PM, Brian Paul <brianp at vmware.com> wrote:
> On 04/22/2012 11:50 AM, Marek Olšák wrote:
>>
>> This fixes an assertion failure since:
>> commit 81afdd20f3f574ce29559d8ad77df5c77652009e
>> vbo: don't check twice whether it's valid to render
>>
>> FLUSH_CURRENT may set _NEW_CURRENT_ATTRIB.
>
>
> These two look OK to me. But the VBO code is kind of touchy so testing is
> the key thing.
>
> Reviewed-by: Brian Paul <brianp at vmware.com>
I always do a piglit run and "nexuiz -nosound -benchmark demos/demo2",
but I didn't use --enable-debug when the assertion failure creeped in.
Sorry about that.
Marek
More information about the mesa-dev
mailing list