[Mesa-dev] [PATCH 03/22] glsl: Add a "ubo_load" expression type for fetches from UBOs.

[Eric Anholt]

Kenneth Graunke <kenneth at whitecape.org> writes:
> On 07/31/2012 03:01 PM, Eric Anholt wrote:
>> diff --git a/src/glsl/ir.h b/src/glsl/ir.h
>> index f019837..2807ba6 100644
>> --- a/src/glsl/ir.h
>> +++ b/src/glsl/ir.h
>> @@ -1018,9 +1018,18 @@ enum ir_expression_operation {
>>     ir_binop_pow,
>>  
>>     /**
>> +    * Load a value the size of a given GLSL type from a uniform block.
>> +    *
>> +    * operand0 is the uniform block index in the linked shader.
>> +    * operand1 is a constant or variable byte offset within the
>
> Constant or variable...you don't say :)
>
> I'd just go with "byte offset within the uniform block".

Err, yeah.  operand 0 should have been clarified to be ir_constant,
while the qualifiers on operand 1 weren't helping.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120806/7561a9b3/attachment.pgp>