[Mesa-dev] [PATCH 17/22] i965: Bind UBOs as surfaces like we do for pull constants.

Eric Anholt eric at anholt.net
Mon Aug 6 18:06:42 PDT 2012


Kenneth Graunke <kenneth at whitecape.org> writes:
> On 07/31/2012 03:01 PM, Eric Anholt wrote:
>> +const struct brw_tracked_state brw_vs_ubo_surfaces = {
>> +   .dirty = {
>> +      .mesa = (_NEW_PROGRAM |
>> +	       _NEW_BUFFER_OBJECT),
>> +      .brw = (BRW_NEW_BATCH),
>
> You don't actually need the extra parenthesis...IMHO,
>
>   .foo = bits | morebits | yetmorebits,
>   .bar = ...
>
> is already quite readable, and definitely unambiguous (the = and , are
> clear delimiters).  Not a big deal either way though.

Yeah, just an artifact of how I copied some other struct and kept
dropping flags out of the middle of the parens.  Fixed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120806/d71274d4/attachment.pgp>


More information about the mesa-dev mailing list