[Mesa-dev] [PATCH] st/mesa: fix renderbuffer validation bug

[Jose Fonseca]

----- Original Message -----
> After we attach a new renderbuffer in this function we need to make
> sure Mesa's update_framebuffer() gets called.
> 
> Fixes crash in WebGL
> conformance/textures/texture-attachment-formats.html,
> but the test still fails for other reasons.
> 
> Fixes ttps://bugs.freedesktop.org/show_bug.cgi?id=53316

ttps - > https

Otherwise looks good. It's nice seeing the webgl conformance test suite finding bugs, and seeing them fixed so quickly!

Jose

> 
> Note: This is a candidate for the 8.0 branch.
> ---
>  src/mesa/state_tracker/st_cb_fbo.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/src/mesa/state_tracker/st_cb_fbo.c
> b/src/mesa/state_tracker/st_cb_fbo.c
> index 7eef5c6..40e3677 100644
> --- a/src/mesa/state_tracker/st_cb_fbo.c
> +++ b/src/mesa/state_tracker/st_cb_fbo.c
> @@ -458,6 +458,12 @@ st_render_texture(struct gl_context *ctx,
>      * passed to the pipe as a (color/depth) render target.
>      */
>     st_invalidate_state(ctx, _NEW_BUFFERS);
> +
> +
> +   /* Need to trigger a call to update_framebuffer() since we just
> +    * attached a new renderbuffer.
> +    */
> +   ctx->NewState |= _NEW_BUFFERS;
>  }
>  
>  
> --
> 1.7.3.4
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>