[Mesa-dev] [PATCH 25/26] mesa/es: Remove redundant glFramebufferTexture3D textarget validation

[Ian Romanick]

On 08/19/2012 11:58 PM, Kenneth Graunke wrote:
> On 08/17/2012 08:11 PM, Ian Romanick wrote:
>> From: Ian Romanick <ian.d.romanick at intel.com>
>>
>> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
>> ---
>>   src/mesa/main/APIspec.xml |    4 ----
>>   1 files changed, 0 insertions(+), 4 deletions(-)
>>
>> diff --git a/src/mesa/main/APIspec.xml b/src/mesa/main/APIspec.xml
>> index dd7bf90..63a2b35 100644
>> --- a/src/mesa/main/APIspec.xml
>> +++ b/src/mesa/main/APIspec.xml
>> @@ -2916,10 +2916,6 @@
>>   		<param name="level" type="GLint"/>
>>   		<param name="zoffset" type="GLint"/>
>>   	</proto>
>> -
>> -	<desc name="textarget" error="GL_INVALID_OPERATION">
>> -		<value name="GL_TEXTURE_3D_OES" category="OES_texture_3D"/>
>> -	</desc>
>>   </template>
>>
>>   <template name="CheckFramebufferStatus" direction="get">
>>
>
> Hmm.  I would've thought the category="OES_texture_3D" tag would cause
> it to only accept this when the OES_texture_3D extension is advertised.
>   But it doesn't seem to.

Mesa always advertises GL_EXT_texture3D (part of OpenGL 1.2) and, 
therefore, OES_texture_3D.  It doesn't check for support because it 
always is supported. :)

> It looks like we happily process this function even without
> OES/EXT_texture_3D support.  Probably wrong, but I doubt anyone is
> likely to run into trouble because of it...
>
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>