[Mesa-dev] [PATCH 02/10] i965: Remove four and a half year old TODO comments about samplers.
Kenneth Graunke
kenneth at whitecape.org
Fri Aug 24 03:05:55 PDT 2012
I can't actually understand what these mean, and they seem to
essentially say "we should simplify things", which is a nice goal but
not very specific.
Presumably things got cleaned up at some point.
Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
---
src/mesa/drivers/dri/i965/brw_wm_sampler_state.c | 4 ----
src/mesa/drivers/dri/i965/gen7_sampler_state.c | 4 ----
2 files changed, 8 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_wm_sampler_state.c b/src/mesa/drivers/dri/i965/brw_wm_sampler_state.c
index 1c61bd0..27f0d70 100644
--- a/src/mesa/drivers/dri/i965/brw_wm_sampler_state.c
+++ b/src/mesa/drivers/dri/i965/brw_wm_sampler_state.c
@@ -328,10 +328,6 @@ static void brw_update_sampler_state(struct brw_context *brw,
}
-/* All samplers must be uploaded in a single contiguous array, which
- * complicates various things. However, this is still too confusing -
- * FIXME: simplify all the different new texture state flags.
- */
static void
brw_upload_samplers(struct brw_context *brw)
{
diff --git a/src/mesa/drivers/dri/i965/gen7_sampler_state.c b/src/mesa/drivers/dri/i965/gen7_sampler_state.c
index 0cf6229..3c8daf9 100644
--- a/src/mesa/drivers/dri/i965/gen7_sampler_state.c
+++ b/src/mesa/drivers/dri/i965/gen7_sampler_state.c
@@ -183,10 +183,6 @@ gen7_update_sampler_state(struct brw_context *brw, int unit,
}
-/* All samplers must be uploaded in a single contiguous array, which
- * complicates various things. However, this is still too confusing -
- * FIXME: simplify all the different new texture state flags.
- */
static void
gen7_upload_samplers(struct brw_context *brw)
{
--
1.7.11.4
More information about the mesa-dev
mailing list