[Mesa-dev] [PATCH 2/5] mesa/es: Validate glGenerateMipmap target in Mesa code rather than the ES wrapper

[Eric Anholt]

Ian Romanick <idr at freedesktop.org> writes:
> diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
> index e6cfbc9..77e9910 100644
> --- a/src/mesa/main/fbobject.c
> +++ b/src/mesa/main/fbobject.c
> @@ -2527,16 +2527,23 @@ _mesa_GenerateMipmapEXT(GLenum target)
>  
>     switch (target) {
>     case GL_TEXTURE_1D:
> +      error = !_mesa_is_desktop_gl(ctx);
> +      break;

Style comment throughout these changes:

Could we just say "error = _mesa_is_gles(ctx)" instead of
!_mesa_is_desktop_gl(ctx)?  All the negates all over the place are
giving me a headache.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120824/0ab85704/attachment.pgp>