[Mesa-dev] [PATCH 5/5] mesa/es: Validate glRenderbufferStorage internalFormat in Mesa code rather than the ES wrapper

[Eric Anholt]

Ian Romanick <idr at freedesktop.org> writes:
>     case GL_RED:
>     case GL_R8:
> +      return ctx->API != API_OPENGLES && ctx->Extensions.ARB_texture_rg
> +         ? GL_RED : 0;

R8 should have the gles3 support case here.

>     case GL_R16:
> -      return ctx->Extensions.ARB_texture_rg ? GL_RED : 0;
> +      return _mesa_is_desktop_gl(ctx) && ctx->Extensions.ARB_texture_rg
> +         ? GL_RED : 0;
>     case GL_RG:
>     case GL_RG8:
> +      return ctx->API != API_OPENGLES && ctx->Extensions.ARB_texture_rg
> +         ? GL_RG : 0;

RG8 should have the gles3 support case here.

>     case GL_RGB10_A2UI:
> -      return ctx->Extensions.ARB_texture_rgb10_a2ui ? GL_RGBA : 0;
> +      return _mesa_is_desktop_gl(ctx) &&
> +             ctx->Extensions.ARB_texture_rgb10_a2ui ? GL_RGBA : 0;

rgb10_a2ui is listed in gles3 spec, page 128.  I think it should be
included here.

Other than the issues mentioned, the series is

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120824/609d4079/attachment.pgp>