[Mesa-dev] [PATCH 17/26] glsl: Record in gl_shader_program whether the program uses GLSL ES.

[Kenneth Graunke]

On 11/30/2012 03:20 PM, Eric Anholt wrote:
> Ian Romanick <idr at freedesktop.org> writes:
>
>> From: Paul Berry <stereotype441 at gmail.com>
>>
>> Previously we recorded just the GLSL version (or the max version, if
>> GLSL 1.10 and GLSL 1.20 programs were linked together).
>>
>> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
>> ---
>>   src/glsl/linker.cpp    | 1 +
>>   src/mesa/main/mtypes.h | 1 +
>>   2 files changed, 2 insertions(+)
>
>> diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
>> index f364ae1..4e5be1f 100644
>> --- a/src/mesa/main/mtypes.h
>> +++ b/src/mesa/main/mtypes.h
>> @@ -2387,6 +2387,7 @@ struct gl_shader_program
>>      GLchar *InfoLog;
>>
>>      unsigned Version;       /**< GLSL version used for linking */
>> +   GLboolean IsEsProg; /**< True if this program uses GLSL ES */
>
> I don't think I would ever type "Es" with a lowercase 's' on the first
> try.  Am I alone?

That definitely is hard to type.  (And oh, wow, is it especially awkward 
in QWERTY...not nearly as bad in Dvorak.)

I still think "IsESProg" is hard to type...I usually end up with 
"IsESPRog" or "IsESPROg".

Other suggestions:
- "ES"
   (nice and short, super easy to type, maybe not the most clear)
- "IsES" or "IsEs"
   (the "Prog" part doesn't really add/clarify anything; we're already
    working with a gl_shader_program.  Capitalization is still hard.)
- "ESProgram"
   (decent to capitalize & type as there's no back-and-forth...)

Preferences?