[Mesa-dev] [PATCH] glcpp: Rewrite line-continuation support to act globally.

Carl Worth cworth at cworth.org
Mon Dec 3 09:39:47 PST 2012

Kenneth Graunke <kenneth at whitecape.org> writes:
> I'm pretty tempted by ralloc_rewrite_tail & ralloc_strn_rewrite_tail.

I still don't like the lack of symmetry here. Maybe bite the bullet and
make the first one ralloc_str_rewrite_tail?

But that "rewrite_tail" keeps feeling so awkward. I think the real
problem is that it's using two words for a single concept, (there's
nothing with "rewrite_head", for example). How about just using
"rewrite" everywhere for this concept?

That would give us the following parallels:

	ralloc_strcat	-> ralloc_str_rewrite
	ralloc_strncat 	-> ralloc_strn_rewrite
	ralloc_asprintf	-> ralloc_asprintf_rewrite

I think I could be happy with that. What do you think?


carl.d.worth at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20121203/3b358f9a/attachment.pgp>

More information about the mesa-dev mailing list