[Mesa-dev] [PATCH 08/13] gallium: fix some comments in p_state.h

[Christoph Bumiller]

On 02/13/2012 05:19 PM, Brian Paul wrote:
> ---
>  src/gallium/include/pipe/p_state.h |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/gallium/include/pipe/p_state.h b/src/gallium/include/pipe/p_state.h
> index f6486f0..72ec04a 100644
> --- a/src/gallium/include/pipe/p_state.h
> +++ b/src/gallium/include/pipe/p_state.h
> @@ -329,7 +329,7 @@ struct pipe_surface
>  {
>     struct pipe_reference reference;
>     struct pipe_resource *texture; /**< resource into which this is a view  */
> -   struct pipe_context *context; /**< context this view belongs to */
> +   struct pipe_context *context; /**< context this surface belongs to */
>     enum pipe_format format;
>  

Actually the term "view" isn't wrong here, a surface is a view into a
resource (aka render target or depth/stencil view in D3D).

See the definition of the struct:
/**
 * A view into a texture that can be bound to a color render target /
 * depth stencil attachment point.
 */
struct pipe_surface
{



>     /* XXX width/height should be removed */
> @@ -463,8 +463,8 @@ struct pipe_vertex_buffer
>  struct pipe_stream_output_target
>  {
>     struct pipe_reference reference;
> -   struct pipe_resource *buffer; /**< buffer into which this is a target view */
> -   struct pipe_context *context; /**< context this view belongs to */
> +   struct pipe_resource *buffer; /**< the output buffer */
> +   struct pipe_context *context; /**< context this SO target belongs to */
>  
>     unsigned buffer_offset;  /**< offset where data should be written, in bytes */
>     unsigned buffer_size;    /**< how much data is allowed to be written */