[Mesa-dev] [PATCH 4/4] i965/gen7: Enable transform feedback as long as kernel support is present.

Eugeni Dodonov eugeni at dodonov.net
Mon Jan 2 15:48:13 PST 2012


On Mon, Jan 2, 2012 at 17:37, Eric Anholt <eric at anholt.net> wrote:

> -   if (intel->gen == 6 || (intel->gen == 7 && override_version >= 30))
> +   if (intel->gen == 6 ||
> +       (intel->gen == 7 && intel->intelScreen->kernel_has_gen7_sol_reset))
>       ctx->Extensions.EXT_transform_feedback = true;
>

If the kernel patch in previous series would return
...
    value = IS_GEN7(dev);
...

the line above could be simplified to:
   if (intel->gen == 6 || intel->intelScreen->kernel_has_gen7_sol_reset)

But on the other hand, it would work either way. The check for GEN7 in
kernel looks cleaner and more logically correct to me, but in any case:
Reviewed-by: Eugeni Dodonov <eugeni.dodonov at intel.com>

-- 
Eugeni Dodonov
<http://eugeni.dodonov.net/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120102/85eca2c4/attachment.htm>


More information about the mesa-dev mailing list