[Mesa-dev] [PATCH] glx: More hacking around versions of XCB that lack GLX_ARB_create_context support

Kenneth Graunke kenneth at whitecape.org
Wed Jan 4 02:57:03 PST 2012


On 01/03/2012 12:32 PM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> Detect whether a new enough version of XCB is installed at configure
> time.  If it is not, don't enable the extension and don't build the
> unit tests.
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
> Using this patch, I was able to successfully build and run both with
> and without updated XCB bits installed.  I think the lesson learned
> here is that it's nonsense for the GLX part of XCB to live in the XCB
> library.  There's only one user, so it should live there.  Seriously.
> 
>  configure.ac             |   19 +++++++++++++++++++
>  src/glx/clientinfo.c     |    5 ++++-
>  src/glx/create_context.c |    2 +-
>  src/glx/glxextensions.c  |    4 ++--
>  tests/glx/Makefile.am    |    4 +++-
>  5 files changed, 29 insertions(+), 5 deletions(-)

Looks okay to me.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>



More information about the mesa-dev mailing list