[Mesa-dev] [PATCH 1/3] swrast: remove calls to _swrast_update_depth/stencil_buffer()

Ian Romanick idr at freedesktop.org
Fri Jan 6 13:16:14 PST 2012


On 01/06/2012 11:43 AM, Brian Paul wrote:
> These functions updated the gl_renderbuffer::_DepthBuffer and
> _StencilBuffer fields.  But those fields are no longer used.

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

> ---
>   src/mesa/swrast/s_context.c |   23 -----------------------
>   1 files changed, 0 insertions(+), 23 deletions(-)
>
> diff --git a/src/mesa/swrast/s_context.c b/src/mesa/swrast/s_context.c
> index 6850a09..9246125 100644
> --- a/src/mesa/swrast/s_context.c
> +++ b/src/mesa/swrast/s_context.c
> @@ -36,7 +36,6 @@
>   #include "swrast.h"
>   #include "s_blend.h"
>   #include "s_context.h"
> -#include "s_depthstencil.h"
>   #include "s_lines.h"
>   #include "s_points.h"
>   #include "s_span.h"
> @@ -546,25 +545,6 @@ _swrast_update_active_attribs(struct gl_context *ctx)
>   }
>
>
> -/**
> - * Update the depth/stencil renderbuffers, if needed.
> - */
> -static void
> -_swrast_update_depth_stencil(struct gl_context *ctx)
> -{
> -   struct gl_framebuffer *drawFb = ctx->DrawBuffer;
> -   struct gl_framebuffer *readFb = ctx->ReadBuffer;
> -
> -   _swrast_update_depth_buffer(ctx, drawFb);
> -   _swrast_update_stencil_buffer(ctx, drawFb);
> -
> -   if (readFb != drawFb) {
> -      _swrast_update_depth_buffer(ctx, readFb);
> -      _swrast_update_stencil_buffer(ctx, readFb);
> -   }
> -}
> -
> -
>   void
>   _swrast_validate_derived( struct gl_context *ctx )
>   {
> @@ -609,9 +589,6 @@ _swrast_validate_derived( struct gl_context *ctx )
>                                 _NEW_TEXTURE))
>            _swrast_update_specular_vertex_add(ctx);
>
> -      if (swrast->NewState&  _NEW_BUFFERS)
> -         _swrast_update_depth_stencil(ctx);
> -
>         swrast->NewState = 0;
>         swrast->StateChanges = 0;
>         swrast->InvalidateState = _swrast_invalidate_state;



More information about the mesa-dev mailing list