[Mesa-dev] [PATCH 08/14] i965: Remove brw_vs_precompile

Kenneth Graunke kenneth at whitecape.org
Mon Jan 9 23:46:04 PST 2012


On 01/09/2012 05:21 PM, Eric Anholt wrote:
> On Fri,  6 Jan 2012 16:49:59 -0800, "Ian Romanick"<idr at freedesktop.org>  wrote:
>> From: Ian Romanick<ian.d.romanick at intel.com>
>>
>> The only error that the vertex shader precompile could generate is
>> when register allocation fails.  Since i965 can spill registers, this
>> should never happen.  It's also not something that can cause a link
>> error.
>
> This change will take those shaders from failing to link to segfaulting.
>
> Yeah, it would be nice to finish register allocation.

Oh, wow, I forgot that we hadn't implemented register spilling in the 
new vertex shader backend.  Yeah, that would be nice.

I also haven't implemented spilling in the FS on Ivybridge...need to 
finish that.  Before I can do that, I need to properly reserve g111-g127 
for use as fake MRFs.  (I had hoped to have a real solution, but never 
managed.)  But it's already broken and should be fixed, so...it 
shouldn't really affect the decision here.



More information about the mesa-dev mailing list