[Mesa-dev] [PATCH] i965/hiz: Don't bind GL_DRAW_FRAMEBUFFER on GLES

[Neil Roberts]

Hi,

Chad Versace <chad.versace at linux.intel.com> wrote:

> [chad]: Make comments more concise. Change the if-condition to be
> compatible with a core context, which may not advertise old extensions.

The change to the if-condition breaks the patch. The problem is this bit
of code in fbobject.c:

static struct gl_framebuffer *
get_framebuffer_target(struct gl_context *ctx, GLenum target)
{
   switch (target) {
   case GL_DRAW_FRAMEBUFFER:
      return ctx->Extensions.EXT_framebuffer_blit && ctx->API == API_OPENGL
	 ? ctx->DrawBuffer : NULL;
   ...
   }
}

That limits using GL_DRAW_FRAMEBUFFER to OpenGL even if the
GL_EXT_framebuffer_blit extension is supported by the context. As I
mentioned in the bug report, maybe it would be better to just remove
that check? Then the patch wouldn't be needed anyway.

Regards,
- Neil