[Mesa-dev] [PATCH] i965/hiz: Don't bind GL_DRAW_FRAMEBUFFER on GLES

[Eric Anholt]

On Thu, 12 Jan 2012 13:44:12 +0000, Neil Roberts <neil at linux.intel.com> wrote:
> Hi,
> 
> Chad Versace <chad.versace at linux.intel.com> wrote:
> 
> > [chad]: Make comments more concise. Change the if-condition to be
> > compatible with a core context, which may not advertise old extensions.

I think when we do core contexts, we'll want to keep flagging
EXT_whatever in the Mesa structures so we don't have to go rewrite all
those checks, anyway.

> The change to the if-condition breaks the patch. The problem is this bit
> of code in fbobject.c:
> 
> static struct gl_framebuffer *
> get_framebuffer_target(struct gl_context *ctx, GLenum target)
> {
>    switch (target) {
>    case GL_DRAW_FRAMEBUFFER:
>       return ctx->Extensions.EXT_framebuffer_blit && ctx->API == API_OPENGL
> 	 ? ctx->DrawBuffer : NULL;
>    ...
>    }
> }
> 
> That limits using GL_DRAW_FRAMEBUFFER to OpenGL even if the
> GL_EXT_framebuffer_blit extension is supported by the context. As I
> mentioned in the bug report, maybe it would be better to just remove
> that check? Then the patch wouldn't be needed anyway.

That would start allowing API that's not supposed to exist in GLES to
work, right?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120112/dc67ba95/attachment.pgp>