[Mesa-dev] [PATCH 2/2] glcpp: Fix so that trailing punctuation does not prevent macro expansion

[Carl Worth]

On Sat, 21 Jan 2012 10:53:20 -0800, Ian Romanick <idr at freedesktop.org> wrote:
> The fix seems correct, but reading that regex made my head hurt.

Thanks. And, yes, it was pretty bad before, and the copying made it much
worse.

> Is there a way to refactor the character classes to be more readable?
> OTHER is basically
> [{PUNCTUATION}{IDENTIFIER_FIRST_CHAR}[:space:]][{PUNCTUATION}[:space:]]*,
> right?

Right, (other than that those classes should be negated). I'll see how
to make something clear before pushing the change.

Thanks for the feedback.

-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120121/a9d686cc/attachment.pgp>