[Mesa-dev] [PATCH 03/17] mesa: Add format unpack for the deprecated integer texture formats.

[Eric Anholt]

On Fri, 20 Jan 2012 17:26:20 -0700, Brian Paul <brianp at vmware.com> wrote:
> On 01/20/2012 04:39 PM, Eric Anholt wrote:
> > This cut and paste is pretty awful.  I'm tempted to do a lot of this
> > using preprocessor tricks for customizing the parameter type from a
> > template function, but that's just a different sort of hideous.
> 
> How about having uint, ushort, ubyte functions and just cast the 
> arguments for the signed versions?
> 
> In any case, Reviewed-by: Brian Paul <brianp at vmware.com>

Were you thinking of patch 6?  In this patch, we really do want to
sign-extend int8 0xf0 to uint32 0xfffffff0, but not uint8.

In patch 6, that's not the case, and we could drop half the variants.
But we've got clamping issues that need to be sorted out, and those will
involve custom functions per from/to combo I think.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120123/fb970364/attachment-0001.pgp>