[Mesa-dev] [PATCH] osmesa: Fix osmesa_context.DataType type.

Jose Fonseca jfonseca at vmware.com
Sat Jan 28 02:25:26 PST 2012


Looks good. These warnings are symptom of are real errors.

It's weird I don't see them. I suppose GLboolean is an int on my system somehow..

Jose

----- Original Message -----
> Fixes these GCC warnings.
> osmesa.c: In function ‘osmesa_renderbuffer_storage’:
> osmesa.c:417: warning: comparison is always false due to limited
> range of data type
> osmesa.c:423: warning: comparison is always false due to limited
> range of data type
> osmesa.c:431: warning: comparison is always false due to limited
> range of data type
> osmesa.c:437: warning: comparison is always false due to limited
> range of data type
> osmesa.c:447: warning: comparison is always false due to limited
> range of data type
> osmesa.c:453: warning: comparison is always false due to limited
> range of data type
> osmesa.c:463: warning: comparison is always false due to limited
> range of data type
> osmesa.c:466: warning: comparison is always false due to limited
> range of data type
> osmesa.c:476: warning: comparison is always false due to limited
> range of data type
> osmesa.c:479: warning: comparison is always false due to limited
> range of data type
> 
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  src/mesa/drivers/osmesa/osmesa.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/mesa/drivers/osmesa/osmesa.c
> b/src/mesa/drivers/osmesa/osmesa.c
> index 0a42741..0ec2d37 100644
> --- a/src/mesa/drivers/osmesa/osmesa.c
> +++ b/src/mesa/drivers/osmesa/osmesa.c
> @@ -75,7 +75,7 @@ struct osmesa_context
>     GLvoid *rowaddr[MAX_HEIGHT];	/*< address of first pixel in each
>     image row */
>     GLboolean yup;		/*< TRUE  -> Y increases upward */
>  				/*< FALSE -> Y increases downward */
> -   GLboolean DataType;
> +   GLenum DataType;
>  };
>  
>  
> --
> 1.7.8.3
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 


More information about the mesa-dev mailing list