[Mesa-dev] [PATCH] osmesa: Fix osmesa_context.DataType type.

[Brian Paul]

On 01/27/2012 11:36 PM, Vinson Lee wrote:
> Fixes these GCC warnings.
> osmesa.c: In function ‘osmesa_renderbuffer_storage’:
> osmesa.c:417: warning: comparison is always false due to limited range of data type
> osmesa.c:423: warning: comparison is always false due to limited range of data type
> osmesa.c:431: warning: comparison is always false due to limited range of data type
> osmesa.c:437: warning: comparison is always false due to limited range of data type
> osmesa.c:447: warning: comparison is always false due to limited range of data type
> osmesa.c:453: warning: comparison is always false due to limited range of data type
> osmesa.c:463: warning: comparison is always false due to limited range of data type
> osmesa.c:466: warning: comparison is always false due to limited range of data type
> osmesa.c:476: warning: comparison is always false due to limited range of data type
> osmesa.c:479: warning: comparison is always false due to limited range of data type
>
> Signed-off-by: Vinson Lee<vlee at freedesktop.org>
> ---
>   src/mesa/drivers/osmesa/osmesa.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/mesa/drivers/osmesa/osmesa.c b/src/mesa/drivers/osmesa/osmesa.c
> index 0a42741..0ec2d37 100644
> --- a/src/mesa/drivers/osmesa/osmesa.c
> +++ b/src/mesa/drivers/osmesa/osmesa.c
> @@ -75,7 +75,7 @@ struct osmesa_context
>      GLvoid *rowaddr[MAX_HEIGHT];	/*<  address of first pixel in each image row */
>      GLboolean yup;		/*<  TRUE  ->  Y increases upward */
>   				/*<  FALSE ->  Y increases downward */
> -   GLboolean DataType;
> +   GLenum DataType;
>   };


Vinson, I'm going to commit this.  It's definitely needed.

-Brian