[Mesa-dev] [PATCH 1/8] i965/msaa: Move {rt, tex}_interleaved into blorp program key.

Chad Versace chad.versace at linux.intel.com
Mon Jul 9 13:35:24 PDT 2012


> @@ -192,6 +192,12 @@ struct brw_blorp_blit_prog_key
>      */
>     unsigned tex_samples;
>  
> +   /* If tex_samples > 0, whether or not the GPU pipeline will be configured
> +    * to read from it as though it were an interleaved MSAA layout.  False if
> +    * tex_samples == 0.
> +    */
> +   bool tex_interleaved;

There's a confusing sentence fragment here.
> +
>     /* Actual number of samples per pixel in the source image. */
>     unsigned src_samples;
>  
> @@ -205,6 +211,12 @@ struct brw_blorp_blit_prog_key
>      */
>     unsigned rt_samples;
>  
> +   /* If rt_samples > 0, whether or not the GPU pipeline will be configured
> +    * to write to it as though it were an interleaved MSAA layout.  False if
> +    * rt_samples == 0.
> +    */
> +   bool rt_interleaved;

Here too.

But you kill these comments in the next patch, so whatever.

Reviewed-by: Chad Versace <chad.versace at linux.intel.com>


More information about the mesa-dev mailing list