[Mesa-dev] [PATCH 1/8] i965/msaa: Move {rt, tex}_interleaved into blorp program key.

[Paul Berry]

On 9 July 2012 13:35, Chad Versace <chad.versace at linux.intel.com> wrote:

> > @@ -192,6 +192,12 @@ struct brw_blorp_blit_prog_key
> >      */
> >     unsigned tex_samples;
> >
> > +   /* If tex_samples > 0, whether or not the GPU pipeline will be
> configured
> > +    * to read from it as though it were an interleaved MSAA layout.
>  False if
> > +    * tex_samples == 0.
> > +    */
> > +   bool tex_interleaved;
>
> There's a confusing sentence fragment here.
>

Oh, wow, that's a pretty bad garden path sentence.  I'll fix it to "If
tex_samples > 0, this boolean indicates whether or not the GPU pipeline
will be configured...".


> > +
> >     /* Actual number of samples per pixel in the source image. */
> >     unsigned src_samples;
> >
> > @@ -205,6 +211,12 @@ struct brw_blorp_blit_prog_key
> >      */
> >     unsigned rt_samples;
> >
> > +   /* If rt_samples > 0, whether or not the GPU pipeline will be
> configured
> > +    * to write to it as though it were an interleaved MSAA layout.
>  False if
> > +    * rt_samples == 0.
> > +    */
> > +   bool rt_interleaved;
>
> Here too.
>
> But you kill these comments in the next patch, so whatever.
>
> Reviewed-by: Chad Versace <chad.versace at linux.intel.com>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120709/a68d548d/attachment.html>